[POC-Issue#5735]: support legacy automate excludeFromFailureFile#202
Closed
Pankraz76 wants to merge 12 commits intoapache:masterfrom
Closed
[POC-Issue#5735]: support legacy automate excludeFromFailureFile#202Pankraz76 wants to merge 12 commits intoapache:masterfrom
legacy automate excludeFromFailureFile#202Pankraz76 wants to merge 12 commits intoapache:masterfrom
Conversation
apply remove this
Pankraz76
commented
May 17, 2025
| private void logExcludeFromFailureFileSuppressions() { | ||
| log.info("logExcludeFromFailureFileSuppressions"); | ||
| log.info(violations.stream() | ||
| .map(violation -> String.format("%s:%s", violation.getViolationClass(), violation.getRule())) |
Author
There was a problem hiding this comment.
Suggested change
| .map(violation -> String.format("%s:%s", violation.getViolationClass(), violation.getRule())) | |
| .map(violation -> String.format("%s=%s", violation.getViolationClass(), violation.getRule())) |
collision: (only works for one)
org.apache.maven.building.DefaultProblem=MissingOverride
org.apache.maven.model.merge.MavenModelMerger=ForLoopVariableCount
org.apache.maven.model.merge.MavenModelMerger=OneDeclarationPerLine
merge:
org.apache.maven.building.DefaultProblem=MissingOverride
org.apache.maven.model.merge.MavenModelMerger=ForLoopVariableCount,OneDeclarationPerLine
Author
|
is this any good @oowekyala @adangel? A simple log to support manual c&p would give quick fix, without breaking anything as just logging. Then writing the keys into file could be next step, but not needed anymore. This is unique action, need to be done only once. So automation would be questionable. |
legacy automating excludeFromFailureFilelegacy automating excludeFromFailureFile
legacy automating excludeFromFailureFilelegacy automate excludeFromFailureFile
This was referenced May 17, 2025
This was referenced May 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
legacyprojects, auto-generation ofexcludeFromFailureFilepmd/pmd#5735maven-pmd-plugin: reactivatePMD- Best practices maven#2331mvn pmd:check > pmd.txtworkaround: